chore(release): 1.6.0-beta.1 - #22
Closed
kevinccbsg wants to merge 1 commit into
Closed
Conversation
TWD Contract Validation
23 passed · 41 failed · 3 warnings · 1 skipped Failed validations./contracts/users-3.0.json
./contracts/posts-3.1.json
./contracts/products-3.0.json
./contracts/events-3.1.json
|
Merged
Member
Author
|
Superseded by #23, which ships this as stable 1.6.0 instead of a prerelease. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for the layout snapshot support merged in #21, plus the failure diagnostics from #20 and the puppeteer bump from #19.
Why a prerelease and not 1.6.0 stable
Two reasons, and the first is the one that matters:
This release cannot claim what 1.5.0 claimed. Sharding shipped stable with the note "no behavior change without
--shard". That is not true here:page.setViewport()now runs on every run, not just when recording, so a run that never touches a layout snapshot still moves from Puppeteer's implicit size to1280x800. A test that happened to depend on the old size can behave differently.twd-js1.10.0 is not published yet. Until it is, there is nomatchLayoutfor the new flags to drive and they do nothing. Shipping that as stable would be shipping a feature nobody can use.So
npm install twd-clikeeps resolving to 1.5.0, andnpm install twd-cli@betagets this. Same pattern asv1.3.0-beta.1,v1.4.0-beta.1andv1.5.0-beta.0.One deviation from your process, flagged for a decision
Your CHANGELOG has no entries for prereleases. Every heading in it is a stable version, and the entry gets written when the stable ships. I wrote one for
1.6.0-beta.1anyway.The reason: the viewport change is not opt-in. Anyone installing
twd-cli@betainherits it whether or not they use snapshots, and with no entry there is nowhere written down that says so. That felt worth breaking the pattern for.If you would rather keep the CHANGELOG clean, say so and I will drop the entry here and fold it into the 1.6.0 stable release instead. It is one commit either way.
What was done
Following the process in
CLAUDE.md:package.jsonto1.6.0-beta.1package-lock.jsonregenerated withnpm run lock:linux, so the version moved in both places it lives, and the lock is the Linux one CI actually consumes. That run also dropped a few"peer": truemarkers, which is the macOS-versus-Linux npm differencelock:linuxexists forconventional-changelogis not used here479 tests still passing.
Suggested release title
Per the convention in
CLAUDE.md, a prerelease takes the tag plus a short descriptor: